[
https://issues.apache.org/jira/browse/HBASE-1730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087387#comment-13087387
]
[email protected] commented on HBASE-1730:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1479/#review1535
-----------------------------------------------------------
I reviewed about half. Nice patch. Thank you.
One feature that hbase-4213 has is that the state of the alter is tracked up in
zk. 4213 doesn't do this but, going via zk would seem to make the transaction
more robust against failure of master. What happens in this patch if master is
shot in the head mid-way threw the alter? What you think Nileema?
src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
<https://reviews.apache.org/r/1479/#comment3489>
White space.
src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
<https://reviews.apache.org/r/1479/#comment3490>
Why catch exception to just rethrow it?
src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java
<https://reviews.apache.org/r/1479/#comment3491>
White space
src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java
<https://reviews.apache.org/r/1479/#comment3492>
You are adding white space.
src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java
<https://reviews.apache.org/r/1479/#comment3493>
Javadoc does not agree w/ what is being actually returned.
src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
<https://reviews.apache.org/r/1479/#comment3494>
HSI is deprecated.
src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
<https://reviews.apache.org/r/1479/#comment3497>
White space.
src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
<https://reviews.apache.org/r/1479/#comment3499>
Why are we waiting between unassigns? To lessen load on cluster?
src/main/java/org/apache/hadoop/hbase/master/HMaster.java
<https://reviews.apache.org/r/1479/#comment3500>
Is there anything in here to stop someone disabling a table or preventing
the load balancer moving regions while this is all going on?
src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegionHandler.java
<https://reviews.apache.org/r/1479/#comment3501>
This looks like you are fixing a bug we have in hbase?
src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java
<https://reviews.apache.org/r/1479/#comment3502>
Missing curly braces
- Michael
On 2011-08-12 06:14:21, Nileema Shingte wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1479/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-08-12 06:14:21)
bq.
bq.
bq. Review request for Dhruba Borthakur, Ted Yu, Michael Stack, and Jonathan
Gray.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. When the master receives an alter table call (addColumn, modifyColumn,
deleteColumn, modifyTable), it updates the .tableinfo and then closes all the
regions of that table. The patch includes:
bq.
bq. 1. Changes to reopen the regions when any of the above operations are
performed.
bq. 2. Best effort is made to preserve the locality of regions by assigning it
a region plan before closing it.
bq. 3. Throttling logic that ensures that only a configurable number of
regions are closed per region server at a time.
bq. 4. alter command in the hbase shell will block until all the regions are
updated, providing a status "x/y regions updated" every second.
bq. 5. alter_async command that works exactly like alter, except that it does
not block for completion or provide the status.
bq. 6. alter_status <table_name> which is a sync call and blocks to provide
the "x/y regions updated" status per second until all regions are updated.
bq. 7. modification in the unit test for enabling alter without disabling the
table.
bq.
bq.
bq. This addresses bug HBASE-1730.
bq. https://issues.apache.org/jira/browse/HBASE-1730
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java f151c77
bq. src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java
13c8b8c
bq. src/main/java/org/apache/hadoop/hbase/ipc/HMasterInterface.java c0aa024
bq. src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
49d1e7c
bq. src/main/java/org/apache/hadoop/hbase/master/BulkReOpen.java
PRE-CREATION
bq. src/main/java/org/apache/hadoop/hbase/master/HMaster.java 8beeb68
bq. src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 57c1140
bq.
src/main/java/org/apache/hadoop/hbase/master/handler/ClosedRegionHandler.java
ae43837
bq.
src/main/java/org/apache/hadoop/hbase/master/handler/TableEventHandler.java
09891aa
bq. src/main/ruby/hbase/admin.rb 4460d6e
bq. src/main/ruby/shell.rb 1ec330f
bq. src/main/ruby/shell/commands/alter.rb 1dd43ad
bq. src/main/ruby/shell/commands/alter_async.rb PRE-CREATION
bq. src/main/ruby/shell/commands/alter_status.rb PRE-CREATION
bq. src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java a32dc99
bq.
bq. Diff: https://reviews.apache.org/r/1479/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. I am putting this up for initial review. I have tested the functionality
in a pseudo distributed mode.
bq. Need to run unit tests.
bq.
bq.
bq. Thanks,
bq.
bq. Nileema
bq.
bq.
> Near-instantaneous online schema and table state updates
> --------------------------------------------------------
>
> Key: HBASE-1730
> URL: https://issues.apache.org/jira/browse/HBASE-1730
> Project: HBase
> Issue Type: Improvement
> Reporter: Andrew Purtell
> Assignee: stack
> Priority: Critical
> Fix For: 0.92.0
>
> Attachments: 1730-v2.patch, 1730-v3.patch, 1730.patch,
> HBASE-1730.patch
>
>
> We should not need to take a table offline to update HCD or HTD.
> One option for that is putting HTDs and HCDs up into ZK, with mirror on disk
> catalog tables to be used only for cold init scenarios, as discussed on IRC.
> In this scheme, regionservers hosting regions of a table would watch
> permanent nodes in ZK associated with that table for schema updates and take
> appropriate actions out of the watcher. In effect, schema updates become
> another item in the ToDo list.
> {{/hbase/tables/<table-name>/schema}}
> Must be associated with a write locking scheme also handled with ZK
> primitives to avoid situations where one concurrent update clobbers another.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
