[ 
https://issues.apache.org/jira/browse/HBASE-11520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-11520:
--------------------------

    Attachment: 11520v2.txt

Thanks for taking a look [~ndimiduk].  v2 has tests for 'heap' and 'file' 
added.  Or were you thinking of something else?  If 'heap', yeah, could OOME if 
we assign too much to onheap bucketcache but that should happen on startup and 
be pretty plain as to what is going on.

Chunhui Shen uses BucketCache onheap.  Its way slower but heap won't fragment 
because of BC operations.

> Simplify offheap cache config by removing the confusing 
> "hbase.bucketcache.percentage.in.combinedcache"
> -------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-11520
>                 URL: https://issues.apache.org/jira/browse/HBASE-11520
>             Project: HBase
>          Issue Type: Sub-task
>          Components: io
>    Affects Versions: 0.99.0
>            Reporter: stack
>            Assignee: stack
>             Fix For: 0.99.0, 2.0.0
>
>         Attachments: 11520.txt, 11520v2.txt
>
>
> Remove "hbase.bucketcache.percentage.in.combinedcache".  It is unnecessary 
> complication of block cache config.  Let L1 config setup be as it is whether 
> a L2 present or not, just set hfile.block.cache.size (not 
> hbase.bucketcache.size * (1.0 - 
> hbase.bucketcache.percentage.in.combinedcache)).  For L2, let 
> hbase.bucketcache.size be the actual size of the bucket cache, not 
> hbase.bucketcache.size * hbase.bucketcache.percentage.in.combinedcache.
> Attached patch removes the config. and updates docs.  Adds tests to confirm 
> configs are as expected whether a CombinedBlockCache deploy or a strict L1+L2 
> deploy.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to