[
https://issues.apache.org/jira/browse/HBASE-4199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087469#comment-13087469
]
Doug Meil commented on HBASE-4199:
----------------------------------
1. BlockCacheSummaryEntry name
I'm struggling with the name. 'BlockCacheSummary' makes it seem like you
should get exactly one object back (I.e., a summary). So what
'BlockCacheSummaryEntry' is intended to be is an entry in the summary.
Is BlockCacheTableCfSummary a better class name?
2. RegionServer returning Lists
Can the interface do this? I thought that everything returned had to implement
Writable. If RegionServers can return Lists, then I think that's a better
structure.
3. Eclipse-generated methods
Equals, hashcode, and the writable signature (e.g., arg0), and toString were
all generated by Eclipse.
4. Cost of method
Yeah, this is not an inexpensive operation, but adding that method to FsUtils
was the only way I could find getting the lookup from StoreFile to CF/Table.
That could be cached, but there are all sorts of issues with cache invalidation
every times a new store-file is written.
5. Default Values
JD told me that BlockCacheSummaryEntry should have those with default values
for the purpose of serialization (same for default constructor)! :-)
> blockCache summary - backend
> ----------------------------
>
> Key: HBASE-4199
> URL: https://issues.apache.org/jira/browse/HBASE-4199
> Project: HBase
> Issue Type: Sub-task
> Reporter: Doug Meil
> Assignee: Doug Meil
> Priority: Minor
> Attachments: java_HBASE_4199.patch, java_HBASE_4199_v2.patch,
> java_HBASE_4199_v3.patch
>
>
> This is the backend work for the blockCache summary. Change to BlockCache
> interface, Summarization in LruBlockCache, BlockCacheSummaryEntry, addition
> to HRegionInterface, and HRegionServer.
> This will NOT include any of the web UI or anything else like that. That is
> for another sub-task.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
