[
https://issues.apache.org/jira/browse/HBASE-4227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13087500#comment-13087500
]
stack commented on HBASE-4227:
------------------------------
Looks great. getDefaultValues looks like it should be a static map though,
what you think Nileema? Something like:
{code}
private final static Map<String, String> DEFAULT_VALUES = new HashMap<String,
String>();
static {
defaultValues.put(BLOOMFILTER, DEFAULT_BLOOMFILTER);
DEFAULT_VALUES.put(REPLICATION_SCOPE,
String.valueOf(DEFAULT_REPLICATION_SCOPE));
DEFAULT_VALUES.put(HConstants.VERSIONS, String.valueOf(DEFAULT_VERSIONS));
DEFAULT_VALUES.put(COMPRESSION, DEFAULT_COMPRESSION);
DEFAULT_VALUES.put(TTL, String.valueOf(DEFAULT_TTL));
DEFAULT_VALUES.put(BLOCKSIZE, String.valueOf(DEFAULT_BLOCKSIZE));
DEFAULT_VALUES.put(HConstants.IN_MEMORY, String.valueOf(DEFAULT_IN_MEMORY));
DEFAULT_VALUES.put(BLOCKCACHE, String.valueOf(DEFAULT_BLOCKCACHE));
}
{code}
No biggie. I can commit w/o it but if you make a new patch that'd be good too.
Thanks.
> Modify the webUI so that default values of column families are not shown
> ------------------------------------------------------------------------
>
> Key: HBASE-4227
> URL: https://issues.apache.org/jira/browse/HBASE-4227
> Project: HBase
> Issue Type: Improvement
> Reporter: Nicolas Spiegelberg
> Assignee: nileema shingte
> Priority: Minor
> Fix For: 0.92.0
>
> Attachments: HBASE-4227.patch
>
>
> With the introduction of online schema changes, it will become more
> advantageous to put configuration knobs at the column family level vs global
> configuration settings. This will create a nasty web UI experience for
> showing table properties unless we default to showing the custom values
> instead of all values. It's on the table if we want to modify the shell's
> 'describe' method as well. scan '.META.' should definitely return the full
> properties however.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
