[ 
https://issues.apache.org/jira/browse/HBASE-2217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14064341#comment-14064341
 ] 

Hadoop QA commented on HBASE-2217:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12656154/HBASE-2217.patch
  against trunk revision .
  ATTACHMENT ID: 12656154

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10099//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10099//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10099//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10099//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10099//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10099//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10099//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10099//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10099//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10099//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10099//console

This message is automatically generated.

> VM OPTS for shell only
> ----------------------
>
>                 Key: HBASE-2217
>                 URL: https://issues.apache.org/jira/browse/HBASE-2217
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: stack
>            Assignee: Andrew Purtell
>             Fix For: 0.99.0, 0.96.3, 0.98.5, 0.94.22, 2.0.0
>
>         Attachments: HBASE-2217.patch
>
>
> Over in hbase-2177 Ryan goes on how enabling gc logging, it shows on stdout 
> when you fire the shell:
> {code}
> so one problem with this is the irb then logs all GC to stdout, which is 
> ugly.  I do something like this in my scripts:
> export HBASE_OPTS=""
> export HBASE_LOG_DIR=<somewhere>
> export SERVER_GC_OPTS="$HBASE_OPTS -verbose:gc 
> -XX:+PrintGCApplicationStoppedTime -XX:+PrintGCDateStamps -XX:+PrintGCDetails 
> -Xloggc:$HBASE_HOME/logs/gc-hbase.log"
> export JMX_OPTS="-Dcom.sun.management.jmxremote.authenticate=true 
> -Dcom.sun.management.jmxremote.ssl=false 
> -Dcom.sun.management.jmxremote.password.file=$HBASE_HOME/conf/jmxremote.password
>  -Dcom.sun.management.jmxremote"
> export HBASE_MASTER_OPTS="$SERVER_GC_OPTS 
> -Xloggc:$HBASE_LOG_DIR/logs/gc-master.log"
> export HBASE_REGIONSERVER_OPTS="$SERVER_GC_OPTS 
> -Xloggc:$HBASE_LOG_DIR/gc-hbase.log -Dcom.sun.management.jmxremote.port=10102 
> $JMX_OPTS"
> export HBASE_THRIFT_OPTS="-Xmx1000m $SERVER_GC_OPTS 
> -Xloggc:$HBASE_LOG_DIR/gc-hbase-thrift.log 
> -Dcom.sun.management.jmxremote.port=10103 $JMX_OPTS"
> export HBASE_ZOOKEEPER_OPTS="-Xmx1000m $SERVER_GC_OPTS 
> -Xloggc:$HBASE_LOG_DIR/gc-zk.log -Dcom.sun.management.jmxremote.port=10104 
> $JMX_OPTS"
> now you get remote JMX with logging to whatever directory (we have to log to 
> our large data partition since logs... can be big).  Also the shell doesnt 
> log GC to stdout, and you can get separate GC logs for hmaster, hrs, thrift, 
> zookeeper.
> {code}
> Need to make an OPTS for the shell to use.... or do the above.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to