[ 
https://issues.apache.org/jira/browse/HBASE-11537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14066572#comment-14066572
 ] 

stack commented on HBASE-11537:
-------------------------------

+1 on patch.  LGTM.  Looking at the synchronizes, I could not see need to keep 
procedures changes in line with other changes in state [~jmhsieh] Do you want 
to take a looksee?  This stuff came in w/ original procedures commit HBASE-7212

> Avoid synchronization on instances of ConcurrentMap
> ---------------------------------------------------
>
>                 Key: HBASE-11537
>                 URL: https://issues.apache.org/jira/browse/HBASE-11537
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Mike Drob
>            Assignee: Mike Drob
>            Priority: Minor
>              Labels: findbugs
>         Attachments: HBASE-11537.patch, HBASE-11537.patch.txt
>
>
> In {{ProcedureCoordinator}} and {{ProcedureMember}} we synchronize on an 
> instance of {{ConcurrentMap}} instead of using the interface methods for 
> dealing with concurrent access.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to