[
https://issues.apache.org/jira/browse/HBASE-11541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067390#comment-14067390
]
Hadoop QA commented on HBASE-11541:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12656701/HBASE-11541.patch
against trunk revision .
ATTACHMENT ID: 12656701
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/10126//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10126//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10126//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10126//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10126//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10126//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10126//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10126//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10126//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10126//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10126//console
This message is automatically generated.
> Wrong result when scaning meta with startRow
> --------------------------------------------
>
> Key: HBASE-11541
> URL: https://issues.apache.org/jira/browse/HBASE-11541
> Project: HBase
> Issue Type: Bug
> Reporter: Liu Shaohui
> Assignee: Liu Shaohui
> Priority: Minor
> Fix For: 0.99.0, 0.98.5, 2.0.0
>
> Attachments: HBASE-11541-trunk-v1.diff, HBASE-11541.patch,
> HBASE-11541.patch
>
>
> When we scan the meta with STARTROW optiion, wrong result may be returned.
> For exmaple: if there are two tables named "a" and "b" in hbase, when we scan
> the meta with startrow = 'b', the region location of table "a" will be
> returned but we expect to get the region location of table "b".
> {code}
> > create 'a', {NAME => 'f'}
> > create 'b', {NAME => 'f'}
> > scan '.META.', {STARTROW => 'b', LIMIT => 1}
> a,,1405655897758.f8b547476b6dc80545e6413c31396, xxxx
> {code}
> The reason is the wrong assumption in MetaKeyComparator
> See: KeyValue.java#2011
> {code}
> int leftDelimiter = getDelimiter(left, loffset, llength,
> HRegionInfo.DELIMITER);
> int rightDelimiter = getDelimiter(right, roffset, rlength,
> HRegionInfo.DELIMITER);
> if (leftDelimiter < 0 && rightDelimiter >= 0) {
> // Nothing between .META. and regionid. Its first key.
> return -1;
> } else if (rightDelimiter < 0 && leftDelimiter >= 0) {
> return 1;
> } else if (leftDelimiter < 0 && rightDelimiter < 0) {
> return 0;
> }
> {code}
> It's a little troublesome to fix this problem for given a start row which
> contains more than two "," for meta, it's not easy to extract the startKey of
> region.
> eg: STARTROW => 'aaa,bbb,ccc,xxx'.
> Comments and suggestions are welcomed. Thanks
--
This message was sent by Atlassian JIRA
(v6.2#6252)
