[
https://issues.apache.org/jira/browse/HBASE-11556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14069314#comment-14069314
]
Hadoop QA commented on HBASE-11556:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12656936/hbase-11556.v2.patch
against trunk revision .
ATTACHMENT ID: 12656936
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 7 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
[email protected]({TestPoolMap.TestRoundRobinPoolType.class,
TestPoolMap.TestThreadLocalPoolType.class,
+ * {@link #batchCallback(List, Object[],
org.apache.hadoop.hbase.client.coprocessor.Batch.Callback)}
[email protected]({TestHTablePool.TestHTableReusablePool.class,
TestHTablePool.TestHTableThreadLocalPool.class})
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/10137//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10137//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10137//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10137//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10137//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10137//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10137//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10137//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10137//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10137//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10137//console
This message is automatically generated.
> Move HTablePool to hbase-thrift module.
> ---------------------------------------
>
> Key: HBASE-11556
> URL: https://issues.apache.org/jira/browse/HBASE-11556
> Project: HBase
> Issue Type: Bug
> Components: Thrift
> Affects Versions: 2.0.0
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: 2.0.0
>
> Attachments: hbase-11556.patch, hbase-11556.v2.patch
>
>
> Thrift2 is the only place in the core hbase project where HTablePool is used.
> HTablePool is currently marked deprecated since 0.98.1 and users have been
> discouraged from using it for a while.
> This patch moves HTablePool to the hbase-thrift module so that we remove it
> from the core client api and group it with the piece of code it is used by.
> We got here because HBASE-11554 attempted to remove what seemed to Reusable
> pooltype, and it ended up that thrift2 defaulted to this Reusable type.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
