[
https://issues.apache.org/jira/browse/HBASE-11564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14070525#comment-14070525
]
stack commented on HBASE-11564:
-------------------------------
Should we implement
http://nick-lab.gs.washington.edu/java/jdk1.5b/api/java/util/concurrent/Cancellable.html
?
If you make a second patch, remove the '-' in below since you went and edited
javadoc
+ * @param cs - the completion service to use for submitting
+ * @param rl - the region locations
+ * @param min - the id of the first replica, inclusive
+ * @param max - the id of the last replica, inclusive.
What does this mean client-side?
+ * This means as well that it can be used for a small set of tasks only.
How small?
Scanned patch. Looks great.
> Improve cancellation management in the rpc layer
> ------------------------------------------------
>
> Key: HBASE-11564
> URL: https://issues.apache.org/jira/browse/HBASE-11564
> Project: HBase
> Issue Type: Bug
> Components: Client
> Affects Versions: 1.0.0, 2.0.0
> Reporter: Nicolas Liochon
> Assignee: Nicolas Liochon
> Fix For: 1.0.0, 2.0.0
>
> Attachments: 11564.v1.patch, 11564.v2.patch
>
>
> The current client code depends on interrupting the thread for canceling a
> request. It's actually possible to rely on a callback in protobuf.
> The patch includes as well various performance improvements in replica
> management.
> On a version before HBASE-11492 the perf was ~35% better. I will redo the
> test with the last version.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
