[
https://issues.apache.org/jira/browse/HBASE-11579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14072217#comment-14072217
]
Hadoop QA commented on HBASE-11579:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12657418/HBASE-11579-v0-trunk.patch
against trunk revision .
ATTACHMENT ID: 12657418
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.io.hfile.TestCacheConfig
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/10163//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10163//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10163//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10163//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10163//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10163//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10163//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10163//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10163//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10163//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10163//console
This message is automatically generated.
> CopyTable should check endtime value only if != 0
> -------------------------------------------------
>
> Key: HBASE-11579
> URL: https://issues.apache.org/jira/browse/HBASE-11579
> Project: HBase
> Issue Type: Bug
> Components: mapreduce
> Affects Versions: 0.99.0, 0.98.4
> Reporter: Jean-Marc Spaggiari
> Assignee: Jean-Marc Spaggiari
> Attachments: HBASE-11579-v0-trunk.patch
>
>
> CopyTable automatically assign an endTime if startTime is specified and
> endTime is node:
> {code}
> if (startTime != 0) {
> scan.setTimeRange(startTime,
> endTime == 0 ? HConstants.LATEST_TIMESTAMP : endTime);
> }
> {code}
> However, we test if endTime is == 0 and exit before we get a chance to set
> the range:
> {code}
> if (startTime > endTime) {
> printUsage("Invalid time range filter: starttime=" + startTime + " >
> endtime=" + endTime);
> return false;
> }
> {code}
> So we need to check endTime only if it's != 0.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
