[
https://issues.apache.org/jira/browse/HBASE-11527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082507#comment-14082507
]
stack commented on HBASE-11527:
-------------------------------
I don't like your moving block cache implementation detail up out of io.hfile
package up into the global HConstants mess but I like the rest of your patch
more than I dislike this violation of encapsulation. +1 to commit if on commit
you add TODO in HConstants that admits these added defines violations and
suggests moving block-cache to hbase-commons or some such (it'd be kinda cool
if block cache implementations could be detached from hbase-server and
hfiles.....).
Good work [~anoop.hbase]
> Cluster free memory limit check should consider L2 block cache size also when
> L2 cache is onheap.
> -------------------------------------------------------------------------------------------------
>
> Key: HBASE-11527
> URL: https://issues.apache.org/jira/browse/HBASE-11527
> Project: HBase
> Issue Type: Bug
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Fix For: 2.0.0
>
> Attachments: HBASE-11527.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.2#6252)
