[
https://issues.apache.org/jira/browse/HBASE-11068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083093#comment-14083093
]
stack commented on HBASE-11068:
-------------------------------
Patch looks good to me.
I ran the patch locally and got similar set of failures:
Results :
testRetainAssignmentOnRestart(org.apache.hadoop.hbase.master.TestRestartCluster):
expected:<172.16.1.127:572[46]> but was:<172.16.1.127:572[39]>
testFencingAroundCompactionAfterWALSync(org.apache.hadoop.hbase.TestIOFencing):
Timed out waiting for the region to flush
testRebalanceOnRegionServerNumberChange[1](org.apache.hadoop.hbase.TestRegionRebalancing):
After 5 attempts, region assignments were not balanced.
Tests in error:
org.apache.hadoop.hbase.client.TestReplicasClient: KeeperErrorCode = NoNode
for /hbase/region-in-transition/1588230740
testMasterOpsWhileSplitting(org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction):
Failed to report opened region to master:
TestSplit,lll,1406927556923.e5d051a237ee9d5837baca3565f474d3.
org.apache.hadoop.hbase.regionserver.TestRegionReplicas: KeeperErrorCode =
NoNode for /hbase/region-in-transition/1588230740
Tests run: 2064, Failures: 4, Errors: 3, Skipped: 19
Difference is hadoopqa failed TestMasterOperationsForRegionReplicas and my
local testing failed TestRegionRebalancing which seems to be failing a bunch of
late. Passes if I rerun it w/ this patch.
> Update code to use Admin factory method instead of constructor
> --------------------------------------------------------------
>
> Key: HBASE-11068
> URL: https://issues.apache.org/jira/browse/HBASE-11068
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.99.0
> Reporter: Carter
> Assignee: Carter
> Fix For: 0.99.0
>
> Attachments: HBASE_11068-branch-1-v2.patch, HBASE_11068.patch
>
>
> Where feasible, the code should be updated to use the HConnection factory
> method for the admin interface. For instance, the following:
> {code:java}
> HBaseAdmin admin = new HBaseAdmin(conf);
> {code}
> would be changed to:
> {code:java}
> Admin admin = HConnectionManager.createConnection(conf).getAdmin();
> {code}
> This would also require updates to admin calls that refer to a tablename as
> byte[] or String.
> {code:java}
> admin.enableTable("mytable");
> {code}
> would change to:
> {code:java}
> admin.enableTable(TableName.valueOf("mytable"));
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
