[
https://issues.apache.org/jira/browse/HBASE-4225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089567#comment-13089567
]
Ted Yu commented on HBASE-4225:
-------------------------------
Please use tool such as dos2unix to remove extra new lines.
{code}
+^M
+public class OperationStatus {^
{code}
Please add javadoc for the new class explaining its purpose. It allows adding
more details for operation status in the future.
> NoSuchColumnFamilyException in multi doesn't say which family is bad
> --------------------------------------------------------------------
>
> Key: HBASE-4225
> URL: https://issues.apache.org/jira/browse/HBASE-4225
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Priority: Critical
> Fix For: 0.90.5
>
> Attachments: HBASE-4225_0.90.patch, HBASE-4225_0.90_1.patch,
> HBASE-4225_0.90_2.patch
>
>
> It's kind of a dumb one, in HRegion.doMiniBatchPut we do:
> {code}
> LOG.warn("No such column family in batch put", nscf);
> batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
> {code}
> So we lose the family here, all we know is there's a bad one, that's what's
> in HRS.multi:
> {code}
> } else if (code == OperationStatusCode.BAD_FAMILY) {
> result = new NoSuchColumnFamilyException();
> {code}
> We can't just throw the exception like that, we need to say which one is bad
> even if it requires testing all passed MultiActions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira