[
https://issues.apache.org/jira/browse/HBASE-11318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14085217#comment-14085217
]
Hudson commented on HBASE-11318:
--------------------------------
FAILURE: Integrated in HBase-TRUNK #5366 (See
[https://builds.apache.org/job/HBase-TRUNK/5366/])
HBASE-11318 Classes in security subpackages missing @InterfaceAudience
annotations (Jonathan Hsieh and Andrew Purtell) (apurtell: rev
757b13dea44b93567d761b2ea5346e79de30dfef)
*
hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/TablePermission.java
*
hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityLabelsValidator.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlLists.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslStatus.java
* hbase-common/src/main/java/org/apache/hadoop/hbase/security/UserProvider.java
*
hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/Permission.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/security/SecurityUtil.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/TableAuthManager.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/ZKPermissionWatcher.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationTokenSecretManager.java
*
hbase-client/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcClient.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/ZKSecretWatcher.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/TokenProvider.java
*
hbase-client/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationTokenIdentifier.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/expression/Operator.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/security/SaslUtil.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBasePolicyProvider.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/TokenUtil.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessControlFilter.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/security/AuthMethod.java
*
hbase-client/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationTokenSelector.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/security/SecurityInfo.java
*
hbase-client/src/main/java/org/apache/hadoop/hbase/security/visibility/Authorizations.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationKey.java
*
hbase-client/src/main/java/org/apache/hadoop/hbase/security/access/UserPermission.java
*
hbase-client/src/main/java/org/apache/hadoop/hbase/security/SecureBulkLoadUtil.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/security/HBaseSaslRpcServer.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/security/HBaseKerberosUtils.java
> Classes in security subpackages missing @InterfaceAudience annotations.
> -----------------------------------------------------------------------
>
> Key: HBASE-11318
> URL: https://issues.apache.org/jira/browse/HBASE-11318
> Project: HBase
> Issue Type: Sub-task
> Components: security
> Affects Versions: 0.99.0, 0.96.1.1, 0.98.3
> Reporter: Jonathan Hsieh
> Assignee: Andrew Purtell
> Fix For: 0.99.0, 0.98.5, 2.0.0
>
> Attachments: HBASE-11318_v2.patch, hbase-11318.patch
>
>
> I was reading some of the security related code and noticed that many of the
> security related classes lack @InterfaceAudience markings.
> WIth the current api I believe all but Permission should be Private. With
> the introduction of cell level ACL's Permission must be public because it is
> now exposed in the Mutation setACL calls[1].
> There is an inconsistency with the Mutation ACL -- the acl setters take
> Permission instances but the getter returns byte[]'s. As a follow on issue
> we could change the signature of Mutation.setACL so we don't have to expose
> the Permission class and convert it to be byte[], or change the getter to
> return an exposed Permission instance.
> [1]
> http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/client/Mutation.html#setACL(java.util.Map)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
