[
https://issues.apache.org/jira/browse/HBASE-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13089670#comment-13089670
]
stack commented on HBASE-4217:
------------------------------
A few comments Ram.
The method you add to HBaseAdmin needs a different name and the javadoc needs
to better specify that what we are expecting is the encoded region name. So
something like closeRegionWithEncodedRegionName. Then the javadoc for
regionname should explain what the encoded part of a region name is. You need
to better differentiate this method from the other two closeRegion methods that
are in HBaseAdmin.
Similar for the new method added to the HRegionInterface (and you don't need
javadoc in HRS since its implementing the Interface so it shoudl inherit the
Interface doc)
Do we not have a TestAdmin class already? Should these new tests go in there
instead or into class of their own?
Otherwise, patch looks great Ram...
Oh, what about updating the shell so when you do close_region, it uses your new
method?
Good stuff.
> HRS.closeRegion should be able to close regions with only the encoded name
> --------------------------------------------------------------------------
>
> Key: HBASE-4217
> URL: https://issues.apache.org/jira/browse/HBASE-4217
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.90.4
> Reporter: Jean-Daniel Cryans
> Assignee: ramkrishna.s.vasudevan
> Fix For: 0.92.0
>
> Attachments: HBASE-4217.patch, HBASE-4217_1.patch
>
>
> We had some sort of an outage this morning due to a few racks losing power,
> and some regions were left in the following state:
> ERROR: Region UNKNOWN_REGION on sv4r17s9:60020,
> key=e32bbe1f48c9b3633c557dc0291b90a3, not on HDFS or in META but deployed on
> sv4r17s9:60020
> That region was deleted by the master but the region server never got the
> memo. Right now there's no way to force close it because HRS.closeRegion
> requires an HRI and the only way to create one is to get it from .META. which
> in our case doesn't contain a row for that region. Basically we have to wait
> until that server is dead to get rid of the region and make hbck happy.
> The required change is to have closeRegion accept an encoded name in both HBA
> (when the RS address is provided) and HRS since it's able to find it anyways
> from it's list of live regions.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
