[ 
https://issues.apache.org/jira/browse/HBASE-11626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14090581#comment-14090581
 ] 

cuijianwei commented on HBASE-11626:
------------------------------------

[~apurtell], sorry for replying late. I agree that we shouldn't move a region 
to a dead or invalid location:). There might be situations that users pass an 
unexpected server name(for example, copy the server name from page of another 
hbase cluster) to the 'move region' command, they might not realize the mistake 
and thought to pass the correct address. Then, the region will be closed and 
reopened, and can't serve business in this period. We can discover such 
mistakes earlier before closing the region, so that reduce the impact caused by 
misoperation. Users should be careful enough to do such operation, and we could 
try to help them not to make mistakes:)

> Region will be closed if user try to move it to an error destination server
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-11626
>                 URL: https://issues.apache.org/jira/browse/HBASE-11626
>             Project: HBase
>          Issue Type: Improvement
>          Components: master
>    Affects Versions: 0.98.4
>            Reporter: cuijianwei
>            Priority: Minor
>
> When moving region to a destination server by hbase shell command, such as:
> {code}
> move '7dbe79eb3a77df085c8546b2ee540e7f', 'localhost,58220,1406806842691'
> {code}
> user could pass an error destination server name, such as misspellinging the 
> server name. Then, HMaster will close the region firstly and then assign the 
> region to a random server when finding the destination server is not online, 
> and the region can not serve before it is online again. Do we need to check 
> the destination server name corresponds to an online server before closing 
> region?(in HMaster.move(...)) 
> {code}
> ...
> if (destServerName == null || destServerName.length == 0) {
>       ....
>     } else {
>       dest = ServerName.valueOf(Bytes.toString(destServerName));
>       if (dest.equals(regionState.getServerName())) {
>          ...
>       }
>       // ### check the destination sever is online before closing region ###
>     }
> ...
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to