[
https://issues.apache.org/jira/browse/HBASE-11718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14092771#comment-14092771
]
Jonathan Hsieh commented on HBASE-11718:
----------------------------------------
{quote}
int whatIsLeftToRead = totalSize - readSoFar;
- if (LOG.isDebugEnabled()) {
- LOG.debug("Unknown callId: " + id + ", skipping over this response
of " +
- whatIsLeftToRead + " bytes");
- }
{quote}
This looks like an unexpected error path -- shouldn't we keep it to provide
some indication a client is doing something fishy?
+1 the other removals -- they look like the normal case critical path code.
> Remove some logs in RpcClient.java
> ----------------------------------
>
> Key: HBASE-11718
> URL: https://issues.apache.org/jira/browse/HBASE-11718
> Project: HBase
> Issue Type: Bug
> Components: Client
> Affects Versions: 1.0.0, 2.0.0
> Reporter: Nicolas Liochon
> Assignee: Nicolas Liochon
> Fix For: 1.0.0, 2.0.0
>
> Attachments: 11718.v1.patch
>
>
> All the debug level logs there are about connection start/stop, except a few
> that are per request. As a result, we log too much when we're at the debug
> log level. It could be changed to "trace", but when you're at the trace level
> you usually end up with a debugger to have all the info you need, so I think
> it's better to remove them.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
