[ 
https://issues.apache.org/jira/browse/HBASE-11405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14094167#comment-14094167
 ] 

Sean Busbey commented on HBASE-11405:
-------------------------------------

{noformat}
busbey2-MBA:hbase busbey$ git status
On branch master
Your branch is up-to-date with 'origin/master'.

nothing to commit, working directory clean
busbey2-MBA:hbase busbey$ git apply --check 
~/Downloads/HBASE-11405-trunk.patch.1 
error: patch failed: 
hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java:105
error: hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java: 
patch does not apply
error: patch failed: 
hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java:36
error: 
hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java: 
patch does not apply
{noformat}

Patch no longer applies to master. [~bharathv] can you rebase?

Could you then also upload to ReviewBoard so it's easier to give review 
feedback?

> Multiple invocations of hbck in parallel disables balancer permanently 
> -----------------------------------------------------------------------
>
>                 Key: HBASE-11405
>                 URL: https://issues.apache.org/jira/browse/HBASE-11405
>             Project: HBase
>          Issue Type: Bug
>          Components: Balancer, hbck
>    Affects Versions: 0.99.0
>            Reporter: bharath v
>            Assignee: bharath v
>         Attachments: HBASE-11405-trunk.patch, HBASE-11405-trunk.patch.1
>
>
> This is because of the following piece of code in hbck
> {code:borderStyle=solid}
>   boolean oldBalancer = admin.setBalancerRunning(false, true);
>     try {
>       onlineConsistencyRepair();
>     }
>     finally {
>       admin.setBalancerRunning(oldBalancer, false);
>     }
> {code}
> Newer invocations set oldBalancer to false as it was disabled by previous 
> invocations and this disables balancer permanently unless its manually turned 
> on by the user. Easy to reproduce, just run hbck 100 times in a loop in 2 
> different sessions and you can see that balancer is set to false in the 
> HMaster logs.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to