[
https://issues.apache.org/jira/browse/HBASE-11550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14095661#comment-14095661
]
Nick Dimiduk commented on HBASE-11550:
--------------------------------------
Most of patch v3 is converting the {{int[]}} to {{List<Integer>}}; I see no
value in this change. Please undo this part of the refactor. Otherwise, the
refactor to remove {{bucketSizes}} local variable from BucketCache and sorting
the custom config are good changes. I'm happy to commit such a patch.
One more time [~gustavoanatoly]? Thanks a lot for sticking with it!
> Bucket sizes passed through BUCKET_CACHE_BUCKETS_KEY should be validated
> ------------------------------------------------------------------------
>
> Key: HBASE-11550
> URL: https://issues.apache.org/jira/browse/HBASE-11550
> Project: HBase
> Issue Type: Task
> Reporter: Ted Yu
> Assignee: Gustavo Anatoly
> Attachments: HBASE-11550-v1.patch, HBASE-11550-v2.patch,
> HBASE-11550-v3.patch, HBASE-11550.patch
>
>
> User can pass bucket sizes through "hbase.bucketcache.bucket.sizes" config
> entry.
> The sizes are supposed to be in increasing order. Validation should be added
> in CacheConfig#getL2().
--
This message was sent by Atlassian JIRA
(v6.2#6252)
