[ 
https://issues.apache.org/jira/browse/HBASE-11724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14095863#comment-14095863
 ] 

Jonathan Hsieh commented on HBASE-11724:
----------------------------------------


{quote}
You can do what ever you want.. but the fact that it says "share" it should 
point you to the fact that is a float.
{quote}

Initially I interpreted share as a verb and thought it was boolean with 0 and 
1.  

{quote}
Any help with the wording? to me "Used in conjunction with 
hbase.ipc.server.callqueue.read.share will split the read call queues into 
small-read and long-read queues" is already clear enough and after that there 
is also explained the 0 - 1 corner case... so if you have something to add feel 
free to post it.
{quote}

Give examples in the hbase-defaults.xml for these settings -- it would clarify 
some of the confusion I've encountered.  Give an example settings for scenarios 
where you have gets and scans as equals, where gets get a lot more priority and 
where scans get a lot more priority.  Probably want the same with writes vs 
gets/scans as well.

{quote}
Yeah, you can put 42 and it will be solved by "if ((numReadQueues - 
numScanQueues) > 0)"
{quote}
my point is that as a user you are asking me to look at the code.  Let's assume 
I'm a clever user and looked at the code --- you haven't made any of these 
invariants known.  comments in the hbase-defaults or explicit checks in code 
would be helpful.




> Add to RWQueueRpcExecutor the ability to split get and scan handlers
> --------------------------------------------------------------------
>
>                 Key: HBASE-11724
>                 URL: https://issues.apache.org/jira/browse/HBASE-11724
>             Project: HBase
>          Issue Type: New Feature
>          Components: IPC/RPC
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-11724-v0.patch
>
>
> RWQueueRpcExecutor has the devision between reads and writes requests, but we 
> can split also small-reads and long-reads. This can be useful to force a 
> deprioritization of scans on the RS.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to