[ 
https://issues.apache.org/jira/browse/HBASE-11713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14097323#comment-14097323
 ] 

Andrew Purtell commented on HBASE-11713:
----------------------------------------

The v3 patch is fine, but to nitpick:
{code}
+  private static final String MASTER_COPROCESSORS = 
"hbase.coprocessor.master.classes";
+  private static final String REGION_COPROCESSORS = 
"hbase.coprocessor.region.classes";
{code}
These could be defined somewhere globally (HConstants?) Anyway, +1 here

> Adding hbase shell unit test coverage for visibility labels.
> ------------------------------------------------------------
>
>                 Key: HBASE-11713
>                 URL: https://issues.apache.org/jira/browse/HBASE-11713
>             Project: HBase
>          Issue Type: Test
>          Components: security, shell
>            Reporter: Srikanth Srungarapu
>            Assignee: Srikanth Srungarapu
>            Priority: Minor
>         Attachments: HBASE-11713.patch, HBASE-11713_v2.patch, 
> HBASE-11713_v3.patch
>
>
> Adding test coverage for visibility labels to hbase shell. Also, refactoring 
> existing tests so that all the unit tests related to visibility can be found 
> in one place.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to