[ 
https://issues.apache.org/jira/browse/HBASE-11762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14101446#comment-14101446
 ] 

Andrew Purtell edited comment on HBASE-11762 at 8/18/14 10:41 PM:
------------------------------------------------------------------

Comments on v5 patch:

- WALHdrContext should be static

- ReaderBase still uses a string returned by initReader instead of the new 
context class

- initAfterCompression should take a context object instead of a string now?


was (Author: apurtell):
Comments on v6 patch:

- WALHdrContext should be static

- ReaderBase still uses a string returned by initReader instead of the new 
context class

- initAfterCompression should take a context object instead of a string now?

- 

> Record the class name of Codec in WAL header
> --------------------------------------------
>
>                 Key: HBASE-11762
>                 URL: https://issues.apache.org/jira/browse/HBASE-11762
>             Project: HBase
>          Issue Type: Task
>          Components: wal
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 1.0.0, 2.0.0, 0.98.6
>
>         Attachments: 11762-v1.txt, 11762-v2.txt, 11762-v4.txt, 11762-v5.txt
>
>
> In follow-up discussion to HBASE-11620, Enis brought up this point:
> Related to this, should not we also write the CellCodec that we use in the 
> WAL header. Right now, the codec comes from the configuration which means 
> that you cannot read back the WAL files if you change the codec.
> This JIRA is to implement the above suggestion.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to