[
https://issues.apache.org/jira/browse/HBASE-4955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14105190#comment-14105190
]
Nicolas Liochon commented on HBASE-4955:
----------------------------------------
bq. I wonder if this should give up and fail if we try for too long?
We could. At the end of the day, it's a surefire bug: it should stop properly
the process.
bq. Could you be a bit more detailed on the things which we should fix to get
this through?
On the previous test, we did not generate the final report (iirc it was the
issue I got as well a few months ago). I don't know how to fix this.
On the test you relaunched, it worked. I don't know if it's linked to this new
surefire version, and what is the probability to have the issue.
I'm going to commit the patch, we will see and we can always revert. Guys,
don't hesitate to revert. I'm leaving the office at 6pm my time today, so if
there is an issue during the bay area office hours I won't be able to handle it.
> Use the official versions of surefire & junit
> ---------------------------------------------
>
> Key: HBASE-4955
> URL: https://issues.apache.org/jira/browse/HBASE-4955
> Project: HBase
> Issue Type: Improvement
> Components: test
> Affects Versions: 0.94.0, 0.98.0, 0.96.0, 0.99.0
> Environment: all
> Reporter: Nicolas Liochon
> Assignee: Alex Newman
> Priority: Critical
> Attachments: 4955.v1.patch, 4955.v2.patch, 4955.v2.patch,
> 4955.v2.patch, 4955.v2.patch, 4955.v3.patch, 4955.v3.patch, 4955.v3.patch,
> 4955.v4.patch, 4955.v4.patch, 4955.v4.patch, 4955.v4.patch, 4955.v4.patch,
> 4955.v4.patch, 4955.v5.patch, 4955.v6.patch, 4955.v7.patch, 4955.v7.patch,
> 4955.v8.patch, 4955.v9.patch, 8204.v4.patch, HBASE-4955-v10.patch,
> HBASE-4955-v10.patch, HBASE-4955-v10.patch
>
>
> We currently use private versions for Surefire & JUnit since HBASE-4763.
> This JIRA traks what we need to move to official versions.
> Surefire 2.11 is just out, but, after some tests, it does not contain all
> what we need.
> JUnit. Could be for JUnit 4.11. Issue to monitor:
> https://github.com/KentBeck/junit/issues/359: fixed in our version, no
> feedback for an integration on trunk
> Surefire: Could be for Surefire 2.12. Issues to monitor are:
> 329 (category support): fixed, we use the official implementation from the
> trunk
> 786 (@Category with forkMode=always): fixed, we use the official
> implementation from the trunk
> 791 (incorrect elapsed time on test failure): fixed, we use the official
> implementation from the trunk
> 793 (incorrect time in the XML report): Not fixed (reopen) on trunk, fixed on
> our version.
> 760 (does not take into account the test method): fixed in trunk, not fixed
> in our version
> 798 (print immediately the test class name): not fixed in trunk, not fixed in
> our version
> 799 (Allow test parallelization when forkMode=always): not fixed in trunk,
> not fixed in our version
> 800 (redirectTestOutputToFile not taken into account): not yet fix on trunk,
> fixed on our version
> 800 & 793 are the more important to monitor, it's the only ones that are
> fixed in our version but not on trunk.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
