[
https://issues.apache.org/jira/browse/HBASE-4007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13091612#comment-13091612
]
stack commented on HBASE-4007:
------------------------------
@Prakash Yeah, can be non-intuitive uploading patches to RB. Let me try one
later or if you want to retry, dump in here steps and what you chose and I'll
try what you did.
ConcurrentSet sounds fine. Gives you a 'view' at a particular time. Looks
like it should be fine for deadworkers. If you go the ConcurrentSet route, it
looks like it will make the patch a little simpler. You can get rid of the
local copy you sometimes make as in here:
{code}
+ if (localDeadWorkers != null && localDeadWorkers.contains(cur_worker))
{
{code}
.. and just go against actual set (can remove the null check too?)
Otherwise, patch looks fine to me.
> distributed log splitting can get indefinitely stuck
> ----------------------------------------------------
>
> Key: HBASE-4007
> URL: https://issues.apache.org/jira/browse/HBASE-4007
> Project: HBase
> Issue Type: Bug
> Reporter: Prakash Khemani
> Assignee: Prakash Khemani
> Priority: Critical
> Attachments:
> 0001-HBASE-4007-distributed-log-splitting-can-get-indefin.patch
>
>
> After the configured number of retries SplitLogManager is not going to
> resubmit log-split tasks. In this situation even if the splitLogWorker that
> owns the task dies the task will not get resubmitted.
> When a regionserver goes away then all the split-log tasks that it owned
> should be resubmitted by the SplitLogMaster.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
