[
https://issues.apache.org/jira/browse/HBASE-11800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14106318#comment-14106318
]
Hadoop QA commented on HBASE-11800:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12663561/HBASE-11800_2.patch
against trunk revision .
ATTACHMENT ID: 12663561
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 7
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 site{color}. The patch appears to cause mvn site goal to
fail.
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/10528//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10528//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10528//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10528//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10528//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10528//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10528//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10528//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10528//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10528//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10528//console
This message is automatically generated.
> Coprocessor service methods in HTableInterface should be annotated public
> -------------------------------------------------------------------------
>
> Key: HBASE-11800
> URL: https://issues.apache.org/jira/browse/HBASE-11800
> Project: HBase
> Issue Type: Task
> Components: Client
> Affects Versions: 0.98.0, 0.96.0
> Reporter: Gary Helmling
> Assignee: Gary Helmling
> Attachments: HBASE-11800.patch, HBASE-11800_2.patch
>
>
> The {{HTableInterface.coprocessorService(...)}} and
> {{HTableInterface.batchCoprocessorService(...)}} methods were made private in
> HBASE-9529, when the coprocessor APIs were seen as unstable and evolving.
> However, these methods represent a standard way for clients to use custom
> APIs exposed via coprocessors. In that sense, they are targeted at general
> HBase users (who may run but not develop coprocessors), as opposed to
> coprocessor developers who want to extend HBase.
> The coprocessor endpoint API has also remained much more stable than the
> coprocessor Observer interfaces, which tend to change along with HBase
> internals. So there should not be much difficulty in supporting these
> methods as part of the public API.
> I think we should drop the {{@InterfaceAudience.Private}} annotation on these
> methods and support them as part of the public {{HTableInterface}}.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
