[
https://issues.apache.org/jira/browse/HBASE-11567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14106539#comment-14106539
]
Alex Newman commented on HBASE-11567:
-------------------------------------
+1 overall (although my vote doesn't count). Sorry for not getting this done
sooner, I have been distracted trying to make the build cleaner.
On your comments
1) agreed
2) That makes sense, I did to avoid making fields public. I am down either way
- Overall it looks good however i have some concerns.
- It seems as though the formatting is wrong in some places. Please double
check that you autoindent everything
- I am curious if we should add a unit test (as opposed to regression or
acceptance test) so that the wal entry is only written if everything succeeds.
It would verify that your change is successful.
> Write bulk load COMMIT events to WAL
> ------------------------------------
>
> Key: HBASE-11567
> URL: https://issues.apache.org/jira/browse/HBASE-11567
> Project: HBase
> Issue Type: Sub-task
> Reporter: Enis Soztutar
> Assignee: Alex Newman
> Attachments: HBASE-11567-v1.patch, HBASE-11567-v2.patch,
> hbase-11567-v3.patch
>
>
> Similar to writing flush (HBASE-11511), compaction(HBASE-2231) to WAL and
> region open/close (HBASE-11512) , we should persist bulk load events to WAL.
> This is especially important for secondary region replicas, since we can use
> this information to pick up primary regions' files from secondary replicas.
> A design doc for secondary replica replication can be found at HBASE-11183.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
