[ 
https://issues.apache.org/jira/browse/HBASE-9741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14110278#comment-14110278
 ] 

Elliott Clark commented on HBASE-9741:
--------------------------------------

The stochastic balancer should be using the smaller slop value. Removing the 
value from the defaults.xml just allows the smaller value that is specified as 
the default for the stochastic balancer to be used. However this test was not 
written with the smaller value in mind.

bq.we don't change the default balancer with this patch so I'd assume the test 
would be the same still.
The test asserts that nothing should move; when in reality there might actually 
be a better fit. The larger slop stops the stochastic balancer from searching 
for the better fit. Removing the slop from the defaults just means that the 
test, which was previously written with the old balancer in mind, needs to be 
tweaked to pass with the new effective default.

> Remove hbase.regions.slop from hbase-default.xml
> ------------------------------------------------
>
>                 Key: HBASE-9741
>                 URL: https://issues.apache.org/jira/browse/HBASE-9741
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Elliott Clark
>              Labels: beginner
>         Attachments: HBASE-9741-v0.patch, HBASE-9741-v1.patch, 
> HBASE-9741-v3.patch, HBASE-9741-v4.patch
>
>
> Different balancers have different slop default values.  We should remove 
> hbase.regions.slop from hbase-default.xml



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to