[
https://issues.apache.org/jira/browse/HBASE-11835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14112455#comment-14112455
]
ramkrishna.s.vasudevan commented on HBASE-11835:
------------------------------------------------
{code}
IOUtils.skipFully(in, whatIsLeftToRead);
+ return;
{code}
Should we return after the checking for exception in the header? Because it
tries to close the connection also if fatal. Seeing the other explanations
patch looks good.
> Wrong managenement of non expected calls in the client
> ------------------------------------------------------
>
> Key: HBASE-11835
> URL: https://issues.apache.org/jira/browse/HBASE-11835
> Project: HBase
> Issue Type: Bug
> Components: Client
> Affects Versions: 1.0.0, 2.0.0, 0.98.6
> Reporter: Nicolas Liochon
> Assignee: Nicolas Liochon
> Fix For: 1.0.0, 2.0.0, 0.98.7
>
> Attachments: rpcClient.patch
>
>
> If a call is purged or canceled we try to skip the reply from the server, but
> we read the wrong number of bytes so we corrupt the tcp channel. It's hidden
> as it triggers retry and so on, but it's bad for performances obviously.
> It happens with cell blocks.
> [~ram_krish_86], [[email protected]], you know this part better than me,
> do you agree with the analysis and the patch?
> The changes in rpcServer are not fully related: as the client close the
> connections in such situation, I observed both ClosedChannelException and
> CancelledKeyException.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
