[
https://issues.apache.org/jira/browse/HBASE-11845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113253#comment-14113253
]
Andrew Purtell commented on HBASE-11845:
----------------------------------------
+1 on the 0.98 patch
Technically this removal is not necessary, right? :
{code}
diff --git
a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
index 7eff10a..bc1ec3e 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
@@ -779,11 +779,6 @@ public class HFile {
return res;
}
- public static void main(String[] args) throws IOException {
- HFilePrettyPrinter prettyPrinter = new HFilePrettyPrinter();
- System.exit(prettyPrinter.run(args));
- }
-
/**
* Checks the given {@link HFile} format version, and throws an exception if
* invalid. Note that if the version number comes from an input file and has
{code}
Seems no harm to leave it in 0.98, in case someone is executing HPP via
./bin/hbase org.apache.hadoop.hbase.io.hfile.HFile in scripts or whatnot.
> HFile tool should implement Tool, disable blockcache by default
> ---------------------------------------------------------------
>
> Key: HBASE-11845
> URL: https://issues.apache.org/jira/browse/HBASE-11845
> Project: HBase
> Issue Type: Improvement
> Components: HFile
> Reporter: Nick Dimiduk
> Assignee: Nick Dimiduk
> Priority: Minor
> Fix For: 0.99.0, 2.0.0, 0.98.7
>
> Attachments: HBASE-11845.00-0.98.patch, HBASE-11845.00.patch
>
>
> I tried using bin/hbase hfile in a memory-constrained environment. It crashed
> while trying to instantiate a blockcache. Went to override the configuration
> and found I couldn't.
> Refactor HFile to remove main(), put implementation entirely in
> HFilePrettyPrinter. Said class now extends Configured and implements Tool so
> configs can be overridden on cli. Also disabled blockcache by default.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
