[
https://issues.apache.org/jira/browse/HBASE-11647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14113612#comment-14113612
]
Anoop Sam John commented on HBASE-11647:
----------------------------------------
IntegrationTestIngestMOB
columnDescriptor.setValue(MobConstants.IS_MOB, "true"); You should pass this
as boolean than String?
columnDescriptor.setValue(MobConstants.MOB_THRESHOLD,
String.valueOf(threshold)); - Pass it as long than String?
{code}
} else if(dataGen instanceof LoadTestDataGeneratorMOB) {
LOG.info("Using LoadTestDataGeneratorMOB");
String mobCf = clazzAndArgs[1];
int minMobDataSize = Integer.parseInt(clazzAndArgs[2]);
int maxMobDataSize = Integer.parseInt(clazzAndArgs[3]);
LoadTestDataGeneratorMOB mobDatGen =
(LoadTestDataGeneratorMOB)dataGen;
mobDatGen.configureMob(mobCf.getBytes(), minMobDataSize,
maxMobDataSize);
args = clazzAndArgs.length==4? new String[0] :
Arrays.copyOfRange(clazzAndArgs, 4, clazzAndArgs.length);
} else {
args = clazzAndArgs.length == 1 ? new String[0] :
Arrays.copyOfRange(clazzAndArgs, 1,
clazzAndArgs.length);
}
dataGen.initialize(args);
{code}
hmm this is bad! Why we need this way here? Note the else part and passing all
the args to initialize() You can handle these MOB specific args in
LoadTestDataGeneratorMOB#initialize
{code}
sb.append(COLON);
sb.append(minMobDataSize);
sb.append(COLON);
sb.append(maxMobDataSize);
{code}
Can we not hard code this but take as arg also? Can go with current values as
def value.
{code}
public class LoadTestDataGeneratorMOB
extends MultiThreadedAction.DefaultDataGenerator {
private byte[] mobCf;
private int minMobColDataSize;
private int maxMobColDataSize;
{code}
Unused state variables. Pls remove.
> MOB integration testing
> -----------------------
>
> Key: HBASE-11647
> URL: https://issues.apache.org/jira/browse/HBASE-11647
> Project: HBase
> Issue Type: Sub-task
> Components: Performance, test
> Reporter: Jingcheng Du
> Assignee: Jingcheng Du
> Attachments: HBASE-11647-without-sweep-tool.diff, HBASE-11647.diff
>
>
> The integration testings include the integration function testing and
> performance testing.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
