[ 
https://issues.apache.org/jira/browse/HBASE-11858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14114545#comment-14114545
 ] 

Sean Busbey commented on HBASE-11858:
-------------------------------------

In addition to the fact that it's our [stated 
position|http://hbase.apache.org/book.html#d4145e20682], here are the current 
counts on master that inform my assertion that the missing entries are probably 
private.

{noformat}
busbey2-MBA:hbase busbey$ grep -rl "InterfaceAudience.Private" 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ | wc -l
     132
busbey2-MBA:hbase busbey$ grep -rl "InterfaceAudience.Public" 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ | wc -l
       3
busbey2-MBA:hbase busbey$ grep -rl "InterfaceAudience.LimitedPrivate" 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ | wc -l
       6
busbey2-MBA:hbase busbey$ comm -23 all_regionserver_class.txt 
audience_labeled_class.txt | wc -l
      21
{noformat}

> Audit regionserver classes that are missing InterfaceAudience
> -------------------------------------------------------------
>
>                 Key: HBASE-11858
>                 URL: https://issues.apache.org/jira/browse/HBASE-11858
>             Project: HBase
>          Issue Type: Task
>          Components: regionserver
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Minor
>
> There are ~20 classes in regionserver that are missing InterfaceAudience 
> markers.
> Most are probably private, but HBASE-10378 has already hit atleast one that 
> should be LimitedPrivate(COPROC), so it's worth checking and cleaning things 
> up.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to