[ 
https://issues.apache.org/jira/browse/HBASE-11863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14116194#comment-14116194
 ] 

Hadoop QA commented on HBASE-11863:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12665481/hbase-11863_v1.patch
  against trunk revision .
  ATTACHMENT ID: 12665481

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 6 new 
or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.master.TestMasterFailover
                  org.apache.hadoop.hbase.client.TestMultiParallel
                  
org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor
                  org.apache.hadoop.hbase.client.TestReplicaWithCluster
                  org.apache.hadoop.hbase.replication.TestPerTableCFReplication

     {color:red}-1 core zombie tests{color}.  There are 7 zombie test(s):       
at 
org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClient.testCloneAndRestoreSnapshot(TestRestoreSnapshotFromClient.java:258)
        at 
org.apache.hadoop.hbase.mapreduce.TestRowCounter.testRowCounterHiddenColumn(TestRowCounter.java:137)
        at 
org.apache.hadoop.hbase.mapreduce.TestImportTSVWithVisibilityLabels.testMROnTable(TestImportTSVWithVisibilityLabels.java:162)

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10654//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10654//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10654//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10654//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10654//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10654//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10654//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10654//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10654//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10654//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10654//console

This message is automatically generated.

> WAL files are not archived and stays in the WAL directory after splitting 
> --------------------------------------------------------------------------
>
>                 Key: HBASE-11863
>                 URL: https://issues.apache.org/jira/browse/HBASE-11863
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>            Priority: Blocker
>             Fix For: 0.99.0, 2.0.0, 0.98.6
>
>         Attachments: hbase-11863_v1-0.98.patch, hbase-11863_v1.patch, 
> hbase-11863_v2.patch
>
>
> In patch HBASE-11094, it seems that we changed the constructor we are using 
> for SplitLogManager, which does not archive the log files after splitting is 
> done to the archive folder. The log files stays in the splitting directory 
> forever and re-split every time the master restarts. 
> It is surprising that our unit tests are passing (since 0.94.4) without any 
> issues. Part of the reason is that the split is actually carried, but the WAL 
> is not moved and thus the -splitting directory never gets deleted. 
> It seems critical to fix in 0.98.6, [[email protected]] FYI. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to