[
https://issues.apache.org/jira/browse/HBASE-11876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Purtell updated HBASE-11876:
-----------------------------------
Comment: was deleted
(was: {color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org
against trunk revision .
ATTACHMENT ID: http:
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10685//console
This message is automatically generated.)
> RegionScanner.nextRaw(...) should not update metrics
> ----------------------------------------------------
>
> Key: HBASE-11876
> URL: https://issues.apache.org/jira/browse/HBASE-11876
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.98.6
> Reporter: Lars Hofhansl
> Assignee: Andrew Purtell
> Fix For: 0.99.0, 2.0.0, 0.98.6
>
> Attachments: HBASE-11876.patch
>
>
> I added the RegionScanner.nextRaw(...) to allow "smart" client to avoid some
> of the default work that HBase is doing, such as {start|stop}RegionOperation
> and synchronized(scanner) for each row.
> Metrics should follow the same approach. Collecting them per row is expensive
> and a caller should have the option to collect those later or to avoid
> collecting them completely.
> We can also save some cycles in RSRcpServices.scan(...) if we updated the
> metric only once/batch instead of each row.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
