[ 
https://issues.apache.org/jira/browse/HBASE-11791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14120711#comment-14120711
 ] 

Jonathan Hsieh commented on HBASE-11791:
----------------------------------------

I did a first pass.  For some parts like the code examples should get someone 
else to review.

This doesn't jive here.  Should be table, then CF, then CF then. ..
{code}
+              <listitem><para>Table</para></listitem>
+              <listitem><para>Column Qualifier (CF)</para></listitem>
+              <listitem><para>Column Family (CQ)</para></listitem>
{code}

nit: is the capitalization correct?
{code}
+                <row>
+                    <entry>ScannerClose</entry>
+                    <entry>Table</entry>
+                    <entry>R</entry>
+                </row>
+                <row>
+                    <entry>ScannerNext</entry>
+                    <entry>Table</entry>
+                    <entry>R</entry>
+                </row>
+                <row>
+                    <entry>ScannerOpen</entry>
+                    <entry>Table|CQ|CF</entry>
+                    <entry>R</entry>
+                </row>
{code}

This doesn't exist any more, (as of 0.95 i believe). remove?
{code}
+              <row>
+                <entry />
+                <entry>Lock/UnlockRow</entry>
+              </row>
{code}

i skipped the minutae of the grants -- need to get someone more familiar to 
review it.

You should proably show a config with both access controller and vis controller 
because there is an order they must be applied in in the confg.

{code}
+            <para>Install and configure the VisibilityController coprocessor, 
by setting the
+              following properties in <filename>hbase-site.xml</filename>. 
These properties take a
+              list of classes, and in practice, you will probably enable the 
AccessController as
+              well, but this configuration example only shows the settings for 
the
+              VisibilityController.</para>
{code}

> Update docs on visibility tags and ACLs, transparent encryption, secure bulk 
> upload
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-11791
>                 URL: https://issues.apache.org/jira/browse/HBASE-11791
>             Project: HBase
>          Issue Type: Task
>          Components: documentation
>            Reporter: Misty Stanley-Jones
>            Assignee: Misty Stanley-Jones
>         Attachments: HBASE-11791-v1.patch, HBASE-11791-v2.patch, HBase 
> Security Features Operators Guide - HBaseCon 2014 - v5.pptx
>
>
> Do a pass on the ACL and tag docs and make sure they are up to date and 
> accurate, expand to cover HBASE-10885, HBASE-11001, HBASE-11002, HBASE-11434



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to