[
https://issues.apache.org/jira/browse/HBASE-10841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14122289#comment-14122289
]
Hadoop QA commented on HBASE-10841:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12666628/hbase-10841_v2.patch
against trunk revision .
ATTACHMENT ID: 12666628
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestShell
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.blur.mapreduce.lib.BlurOutputFormatMiniClusterTest.testBlurOutputFormat(BlurOutputFormatMiniClusterTest.java:170)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/10717//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10717//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10717//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10717//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10717//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10717//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10717//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10717//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10717//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10717//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10717//console
This message is automatically generated.
> Scan,Get,Put,Delete,etc setters should consistently return this
> ---------------------------------------------------------------
>
> Key: HBASE-10841
> URL: https://issues.apache.org/jira/browse/HBASE-10841
> Project: HBase
> Issue Type: Sub-task
> Components: Client, Usability
> Affects Versions: 0.99.0
> Reporter: Nick Dimiduk
> Assignee: Enis Soztutar
> Priority: Minor
> Fix For: 0.99.0, 2.0.0
>
> Attachments: hbase-10841_v1.patch, hbase-10841_v1.patch,
> hbase-10841_v2.patch
>
>
> While addressing review comments on HBASE-10818, I noticed that our {{Scan}}
> class is inconsistent with it's setter methods. Some of them return {{this}},
> other's don't. They should be consistent. I suggest making them all return
> {{this}}, to support chained invocation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
