[
https://issues.apache.org/jira/browse/HBASE-11874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14125497#comment-14125497
]
Anoop Sam John commented on HBASE-11874:
----------------------------------------
bq.findCommonPrefixInFlatKey - would need seperate test cases.
Fine. I can add.
bq.These two comments are bit contradictory. In the if condition we say we are
skipping the cf but in else we are saying we have already included the family
Not really. In these DBE algos, we write the CF name only once as it will be
same in any HFile. The code going to else block means the entire rk is common.
WIth out any check we are sure that the common prefix will include
cell.getFamilyLength() + KeyValue.FAMILY_LENGTH_SIZE as that will be common
across all the Cells in any HFile. I think these make sense.
> Support Cell to be passed to StoreFile.Writer rather than KeyValue
> ------------------------------------------------------------------
>
> Key: HBASE-11874
> URL: https://issues.apache.org/jira/browse/HBASE-11874
> Project: HBase
> Issue Type: Sub-task
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Fix For: 0.99.0, 2.0.0
>
> Attachments: HBASE-11874.patch, HBASE-11874_V2.patch,
> HBASE-11874_V3.patch, HBASE-11874_V3.patch, HBASE-11874_V4.patch,
> HBASE-11874_V5.patch
>
>
> This is the in write path and touches StoreFile.Writer, HFileWriter ,
> HFileDataBlockEncoder and different DataBlockEncoder impl.
> We will have to avoid KV#getBuffer() KV#getKeyOffset/Length() calls.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
