[
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14128017#comment-14128017
]
Anoop Sam John commented on HBASE-11805:
----------------------------------------
Even though it is a bit ugly way to deal with the internal data structure of
WALEdit and tried removing from that, we have to solve this issue. From the
getter we have given back the original data structure and one can play with
that. We have add API in WALEdit and one can add with out calling this but just
by getting the List and adding directly to that. Remove is also like that. The
ideal way would have been to ask for a remove() API.
We can solve this by changing 0.98 code such that we keep the cells in the form
of KeyValues in WALEdit. And the getter will continue to return the original
list so that any removal will actually remove the Cell(KV) from WALEdit. 0.98
scope will get reduced to just deprecate the APIs and so adding the new one.
The new one also will just delegate call to the older one. The 98 internal code
path also will continue to deal with KeyValue based APIs. Pls confirm whether
this is ok [~apurtell].
> KeyValue to Cell Convert in WALEdit APIs
> ----------------------------------------
>
> Key: HBASE-11805
> URL: https://issues.apache.org/jira/browse/HBASE-11805
> Project: HBase
> Issue Type: Improvement
> Components: wal
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Fix For: 0.99.0, 2.0.0, 0.98.7
>
> Attachments: HBASE-11805.patch, HBASE-11805_0.98.patch,
> HBASE-11805_0.98_V2.patch, HBASE-11805_0.99.patch, HBASE-11805_V2.patch,
> HBASE-11805_V3.patch
>
>
> In almost all other main interface class/APIs we have changed KeyValue to
> Cell. But missing in WALEdit. This is public marked for Replication (Well it
> should be for CP also)
> These 2 APIs deal with KVs
> add(KeyValue kv)
> ArrayList<KeyValue> getKeyValues()
> Suggest deprecate them and add for 0.98
> add(Cell kv)
> List<Cell> getCells()
> And just replace from 1.0
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
