[
https://issues.apache.org/jira/browse/HBASE-11934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14128821#comment-14128821
]
Hadoop QA commented on HBASE-11934:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12667772/HBASE-11934.patch
against trunk revision .
ATTACHMENT ID: 12667772
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at org.apache.oozie.test.MiniHCatServer$1.run(MiniHCatServer.java:137)
at
org.apache.oozie.test.XTestCase$MiniClusterShutdownMonitor.run(XTestCase.java:1042)
at org.apache.oozie.test.XTestCase.waitFor(XTestCase.java:686)
at
org.apache.oozie.TestCoordinatorEngineStreamLog.testCoordLogStreaming(TestCoordinatorEngineStreamLog.java:105)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/10814//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10814//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10814//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10814//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10814//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10814//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10814//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10814//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10814//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10814//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10814//console
This message is automatically generated.
> Support KeyValueCodec to encode non KeyValue cells.
> ---------------------------------------------------
>
> Key: HBASE-11934
> URL: https://issues.apache.org/jira/browse/HBASE-11934
> Project: HBase
> Issue Type: Sub-task
> Components: Performance, regionserver, Scanners
> Affects Versions: 0.99.0
> Reporter: Anoop Sam John
> Assignee: Anoop Sam John
> Priority: Critical
> Fix For: 2.0.0, 0.99.1
>
> Attachments: HBASE-11934.patch
>
>
> We have KeyValueCodec as the default RPC codec now. This can only encode
> KeyValue types and need to convert any non KV cell to KeyValue format. This
> is a expensive op.
> {code}
> // This is crass and will not work when KV changes. Also if passed a non-kv
> Cell, it will
> // make expensive copy.
> // Do not write tags over RPC
> KeyValue.oswrite((KeyValue) KeyValueUtil.ensureKeyValue(cell), this.out,
> false);
> {code}
> Now we want Cell to be in entire read path and don't want any copy until we
> write the cell to client.
> The optimization done in the DBE of avoiding copying of value bytes was also
> not getting real advantage bacause of this ensureKeyValue() call at the Codec.
> We can encode and write non KeyValue cells with KV serialization format and
> avoid the recreate.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
