[ 
https://issues.apache.org/jira/browse/HBASE-7767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14128853#comment-14128853
 ] 

Hadoop QA commented on HBASE-7767:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12667762/HBASE-7767.patch
  against trunk revision .
  ATTACHMENT ID: 12667762

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 45 new 
or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 6 
warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release 
audit warnings (more than the trunk's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +        compactStoreFiles(tableDir, htd.getHTableDescriptor(), hri, 
path.getName(), compactOnce, major);
+          if (scc.getTableState(table).inStates(TableState.State.DISABLED, 
TableState.State.DISABLING)) {
+       * @see 
org.apache.hadoop.hbase.TableDescriptors#getTableDescriptors(org.apache.hadoop.fs.FileSystem,
 org.apache.hadoop.fs.Path)
+      assertEquals("Meta should be not in transition", metaState.getState(), 
RegionState.State.OPEN);
+      assertEquals("Meta should be not in transition", metaState.getState(), 
RegionState.State.OPEN);

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       
org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClient
                  
org.apache.hadoop.hbase.coprocessor.TestRegionObserverScannerOpenHook
                  
org.apache.hadoop.hbase.coprocessor.TestBigDecimalColumnInterpreter
                  org.apache.hadoop.hbase.coprocessor.TestMasterObserver
                  
org.apache.hadoop.hbase.coprocessor.TestDoubleColumnInterpreter
                  org.apache.hadoop.hbase.zookeeper.TestTableStateManager
                  
org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithRemove
                  
org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction
                  org.apache.hadoop.hbase.coprocessor.TestWALObserver
                  org.apache.hadoop.hbase.TestClusterBootOrder
                  
org.apache.hadoop.hbase.coprocessor.TestMasterCoprocessorExceptionWithRemove
                  org.apache.hadoop.hbase.coprocessor.TestHTableWrapper
                  
org.apache.hadoop.hbase.master.TestMasterOperationsForRegionReplicas
                  org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint
                  org.apache.hadoop.hbase.coprocessor.TestRowProcessorEndpoint
                  
org.apache.hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles
                  org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot
                  org.apache.hadoop.hbase.coprocessor.TestRegionServerObserver
                  org.apache.hadoop.hbase.coprocessor.TestClassLoading
                  org.apache.hadoop.hbase.client.TestReplicaWithCluster
                  org.apache.hadoop.hbase.coprocessor.TestOpenTableInCoprocessor
                  
org.apache.hadoop.hbase.coprocessor.TestRegionServerCoprocessorExceptionWithAbort
                  org.apache.hadoop.hbase.client.TestSnapshotMetadata
                  org.apache.hadoop.hbase.snapshot.TestExportSnapshot
                  
org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDeletes
                  org.apache.hadoop.hbase.replication.TestPerTableCFReplication
                  org.apache.hadoop.hbase.TestJMXListener
                  org.apache.hadoop.hbase.master.TestDistributedLogSplitting
                  
org.apache.hadoop.hbase.coprocessor.TestBatchCoprocessorEndpoint
                  org.apache.hadoop.hbase.TestGlobalMemStoreSize
                  
org.apache.hadoop.hbase.coprocessor.TestRegionObserverInterface
                  
org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClientWithRegionReplicas
                  org.apache.hadoop.hbase.master.handler.TestCreateTableHandler
                  
org.apache.hadoop.hbase.coprocessor.TestMasterCoprocessorExceptionWithAbort
                  org.apache.hadoop.hbase.zookeeper.TestZooKeeperACL
                  org.apache.hadoop.hbase.coprocessor.TestRegionObserverBypass
                  org.apache.hadoop.hbase.coprocessor.TestCoprocessorStop
                  org.apache.hadoop.hbase.coprocessor.TestAggregateProtocol

     {color:red}-1 core zombie tests{color}.  There are 1 zombie test(s):       
at 
org.apache.hadoop.hbase.client.TestAdmin.testCreateTableRPCTimeOut(TestAdmin.java:1241)

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10813//testReport/
Release audit warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10813//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10813//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10813//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10813//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10813//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10813//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10813//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10813//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10813//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10813//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10813//console

This message is automatically generated.

> Get rid of ZKTable, and table enable/disable state in ZK 
> ---------------------------------------------------------
>
>                 Key: HBASE-7767
>                 URL: https://issues.apache.org/jira/browse/HBASE-7767
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Zookeeper
>    Affects Versions: 2.0.0
>            Reporter: Enis Soztutar
>            Assignee: Andrey Stepachev
>         Attachments: HBASE-7767.patch, HBASE-7767.patch, HBASE-7767.patch, 
> HBASE-7767.patch
>
>
> As discussed table state in zookeeper for enable/disable state breaks our 
> zookeeper contract. It is also very intrusive, used from the client side, 
> master and region servers. We should get rid of it. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to