[
https://issues.apache.org/jira/browse/HBASE-11331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14129211#comment-14129211
]
Enis Soztutar commented on HBASE-11331:
---------------------------------------
Is this right? Assuming HeapByteBuffer here.
{code}
> @Override
> public void
serialize(ByteBuffer destination) {
> - ByteBuffer
dupBuf = this.buf.duplicate();
> -
dupBuf.rewind();
> -
destination.put(dupBuf);
> + // assumes
HeapByteBuffer
> +
destination.put(this.buf.array(), this.buf.arrayOffset()
> +
getSerializedLength() - EXTRA_SERIALIZATION_SPACE);
>
serializeExtraInfo(destination);
> }
{code}
On naming conf, I'll go with whatever you think is better. Agreed with Stack.
Fat release note would be good.
> [blockcache] lazy block decompression
> -------------------------------------
>
> Key: HBASE-11331
> URL: https://issues.apache.org/jira/browse/HBASE-11331
> Project: HBase
> Issue Type: Improvement
> Components: regionserver
> Reporter: Nick Dimiduk
> Assignee: Nick Dimiduk
> Fix For: 2.0.0, 0.98.7, 0.99.1
>
> Attachments: HBASE-11331.00.patch, HBASE-11331.01.patch,
> HBASE-11331.02.patch, HBASE-11331.03.patch, HBASE-11331.04.patch,
> HBASE-11331.05-0.98.patch, HBASE-11331.05.patch, HBASE-11331.06-0.98.patch,
> HBASE-11331.06.patch, HBASE-11331.07-0.98.patch, HBASE-11331.07.patch,
> HBASE-11331LazyBlockDecompressperfcompare.pdf,
> hbase-hbase-master-hor17n36.gq1.ygridcore.net.log, lazy-decompress.02.0.pdf,
> lazy-decompress.02.1.json, lazy-decompress.02.1.pdf, v03-20g-045g-false.pdf,
> v03-20g-045g-true-16h.pdf, v03-20g-045g-true.pdf
>
>
> Maintaining data in its compressed form in the block cache will greatly
> increase our effective blockcache size and should show a meaning improvement
> in cache hit rates in well designed applications. The idea here is to lazily
> decompress/decrypt blocks when they're consumed, rather than as soon as
> they're pulled off of disk.
> This is related to but less invasive than HBASE-8894.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
