[ 
https://issues.apache.org/jira/browse/HBASE-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093392#comment-13093392
 ] 

Ted Yu commented on HBASE-4275:
-------------------------------

This is a useful feature.

{code}
+        conf.getLong("hbase.master.rs-fatals-heapsize", 1*1024*1024));
{code}
Should the config be called "hbase.master.rs.fatals.heapsize" ?
{code}
+    String msg = "Region server " + serverInfo + " reported a fatal error:\n"
{code}
If all master needs is a String, probably we should change the type of 
HServerInfo parameter accordingly.
{code}
+
+public class TestMemoryBoundedLogMessageBuffer {
{code}
Please add a short description for the test class.
{code}
+  private static final String JP_TEXT = "こんにちは";
{code}
Wonderful, I should learn Japanese :-)

> RS should communicate fatal "aborts" back to the master
> -------------------------------------------------------
>
>                 Key: HBASE-4275
>                 URL: https://issues.apache.org/jira/browse/HBASE-4275
>             Project: HBase
>          Issue Type: Improvement
>          Components: master, regionserver
>    Affects Versions: 0.92.0
>            Reporter: Todd Lipcon
>         Attachments: 0005-HBASE-4275.-Report-fatals-to-HMaster.patch
>
>
> When a region server aborts, it should attempt to send an RPC to the master 
> that contains (a) the reason for aborting, and (b) the last several KB of log 
> messages, if available. This should help a lot in debugging.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to