[
https://issues.apache.org/jira/browse/HBASE-11598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14130690#comment-14130690
]
Hadoop QA commented on HBASE-11598:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12668138/HBASE-11598-v0.patch
against trunk revision .
ATTACHMENT ID: 12668138
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 22 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 findbugs{color}. The patch appears to introduce 6 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+
"S\020\003\022\013\n\007SECONDS\020\004\022\013\n\007MINUTES\020\005\022\t\n\005HOURS\020\006"
+
+ new java.lang.String[] { "UserName", "UserGroup", "Namespace",
"TableName", "RemoveAll", "BypassGlobals", "Throttle", });
+ result = result && (Float.floatToIntBits(getShare()) ==
Float.floatToIntBits(other.getShare()));
+ "imit\030\002 \001(\004\022\r\n\005share\030\003
\001(\002\022#\n\005scope\030\004 \001(\016" +
+ new java.lang.String[] { "ReqNum", "ReqSize", "WriteNum",
"WriteSize", "ReadNum", "ReadSize", });
+ private <K> QuotaState getQuotaState(final ConcurrentHashMap<K, QuotaState>
quotasMap, final K key) {
+ public static <K> Map<K, QuotaState> fetchGlobalQuotas(final String type,
final Configuration conf,
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/10843//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10843//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10843//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10843//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10843//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10843//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10843//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10843//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10843//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/10843//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/10843//console
This message is automatically generated.
> Add simple rpc throttling
> -------------------------
>
> Key: HBASE-11598
> URL: https://issues.apache.org/jira/browse/HBASE-11598
> Project: HBase
> Issue Type: New Feature
> Reporter: Matteo Bertozzi
> Assignee: Matteo Bertozzi
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: HBASE-11598-v0.patch
>
>
> Add a simple version of rpc throttling.
> (by simple I mean something that requires less changes as possible to the
> core)
> The idea is to add a hbase:quota table to store the user/table quota
> information.
> Add a couple of API on the client like throttleUser() and throttleTable()
> and on the server side before executing the request we check the quota, if
> not an exception is thrown.
> The quota will be per-machine. There will be a flag "QuotaScope" that will be
> used in the future to specify the quota at "cluster level" instead of per
> machine. (A limit of 100req/min means that each machine can execute
> 100req/min with a scope per-machine).
> This will be the first cut, simple solution that requires verify few changes
> to the core.
> Later on we can make the client aware of the ThrottlingException and deal
> with it in a smarter way.
> Also we need to change a bit the RPC code to be able to yield the operation
> if the quota will be
> available not to far in the future, and avoid going back to the client for
> "few seconds".
> REVIEW BOARD: https://reviews.apache.org/r/23981
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
