[ 
https://issues.apache.org/jira/browse/HBASE-11845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14130927#comment-14130927
 ] 

Hadoop QA commented on HBASE-11845:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12668183/HBASE-11845-addendum.patch
  against trunk revision .
  ATTACHMENT ID: 12668183

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 4 new 
or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       
org.apache.hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10849//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10849//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10849//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10849//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10849//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10849//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10849//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10849//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10849//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10849//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10849//console

This message is automatically generated.

> HFile tool should implement Tool, disable blockcache by default
> ---------------------------------------------------------------
>
>                 Key: HBASE-11845
>                 URL: https://issues.apache.org/jira/browse/HBASE-11845
>             Project: HBase
>          Issue Type: Improvement
>          Components: HFile
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>            Priority: Minor
>             Fix For: 2.0.0, 0.98.7, 0.99.1
>
>         Attachments: HBASE-11845-addendum.patch, HBASE-11845.00-0.98.patch, 
> HBASE-11845.00.patch, HBASE-11845.01-0.98.patch, HBASE-11845.01.patch
>
>
> I tried using bin/hbase hfile in a memory-constrained environment. It crashed 
> while trying to instantiate a blockcache. Went to override the configuration 
> and found I couldn't.
> Refactor HFile to remove main(), put implementation entirely in 
> HFilePrettyPrinter. Said class now extends Configured and implements Tool so 
> configs can be overridden on cli. Also disabled blockcache by default.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to