[
https://issues.apache.org/jira/browse/HBASE-10153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14132018#comment-14132018
]
stack commented on HBASE-10153:
-------------------------------
This looks like nice utility.
This looks like a 'fix', an important change?
- scan.setStartRow(value.getRow());
+ scan.setStartRow(tableSplit.getStartRow());
+ scan.setStopRow(tableSplit.getEndRow());
Patch LGTM.
Anyone more familiar with this tool want to chime in?
> improve VerifyReplication to compute BADROWS more accurately
> ------------------------------------------------------------
>
> Key: HBASE-10153
> URL: https://issues.apache.org/jira/browse/HBASE-10153
> Project: HBase
> Issue Type: Improvement
> Components: Operability, Replication
> Affects Versions: 0.94.14
> Reporter: cuijianwei
> Assignee: cuijianwei
> Fix For: 2.0.0, 0.98.7, 0.99.1
>
> Attachments: HBASE-10153-0.94-v1.patch, HBASE-10153-trunk.patch
>
>
> VerifyReplicaiton could compare the source table with its peer table and
> compute BADROWS. However, the current BADROWS computing method might not be
> accurate enough. For example, if source table contains rows as {r1, r2, r3,
> r4} and peer table contains rows as {r1, r3, r4} BADROWS will be 3 because
> 'r2' in source table will make all the later row comparisons fail. Will it be
> better if the BADROWS is computed to 1 in this situation? Maybe, we can
> compute the BADROWS more accurately in merge comparison?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
