[ 
https://issues.apache.org/jira/browse/HBASE-11805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14132239#comment-14132239
 ] 

Andrew Purtell edited comment on HBASE-11805 at 9/12/14 10:47 PM:
------------------------------------------------------------------

Is the addendum patch the revert? Can we just revert this in SCM and then 
propose in a new JIRA the desired changes? We can take 0.98 out of the fix 
versions here and resolve this.
Edit: An addendum patch that reverts a previous change while introducing new 
changes is hard to track, let's not do that.


was (Author: apurtell):
Is the addendum patch the revert? Can we just revert this in SCM and then 
propose in a new JIRA the desired changes? We can take 0.98 out of the fix 
versions here and resolve this.

> KeyValue to Cell Convert in WALEdit APIs
> ----------------------------------------
>
>                 Key: HBASE-11805
>                 URL: https://issues.apache.org/jira/browse/HBASE-11805
>             Project: HBase
>          Issue Type: Improvement
>          Components: wal
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 0.99.0, 2.0.0, 0.98.7
>
>         Attachments: HBASE-11805.patch, HBASE-11805_0.98.patch, 
> HBASE-11805_0.98_V2.patch, HBASE-11805_0.98_addendum.patch, 
> HBASE-11805_0.99.patch, HBASE-11805_V2.patch, HBASE-11805_V3.patch
>
>
> In almost all other main interface class/APIs we have changed KeyValue to 
> Cell. But missing in WALEdit. This is public marked for Replication (Well it 
> should be for CP also) 
> These 2 APIs deal with KVs
> add(KeyValue kv)
> ArrayList<KeyValue> getKeyValues()
> Suggest deprecate them and add for 0.98
> add(Cell kv) 
> List<Cell> getCells()
> And just replace from 1.0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to