[
https://issues.apache.org/jira/browse/HBASE-11825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Solomon Duskis updated HBASE-11825:
-----------------------------------
Attachment: HBASE_11825_v1.patch
I implemented most of the suggested changes:
- getTable() in the documentation instead of createTable()
- removed the TODO line
- replaced “an Table” with “a Table”
- added try/finally blocks to comments about creating and using connections in
ConnectionFactory and HConnectionManager. Also using
getTable(TableName.valueOf("mytable")) instead of getTable("mytable") in the
comments.
I did not make the change about isConnection(). I’ll defer to the wisdom of
this illustrious group about whether or not isClosed() belongs on Connection or
not.
> Create Connection and ConnectionManager
> ---------------------------------------
>
> Key: HBASE-11825
> URL: https://issues.apache.org/jira/browse/HBASE-11825
> Project: HBase
> Issue Type: Improvement
> Reporter: Carter
> Assignee: Solomon Duskis
> Priority: Critical
> Fix For: 2.0.0, 0.99.1
>
> Attachments: HBASE_11825.patch, HBASE_11825_v1.patch
>
>
> This is further cleanup of the HBase interface for 1.0 after implementing the
> new Table and Admin interfaces. Following Enis's guidelines in HBASE-10602,
> this JIRA will generate a new ConnectionManager to replace HCM and Connection
> to replace HConnection.
> For more detail, this JIRA intends to implement this portion:
> {code}
> interface Connection extends Closeable{
> Table getTable(), and rest of HConnection methods
> getAdmin()
> // no deprecated methods (cache related etc)
> }
> @Deprecated
> interface HConnection extends Connection {
> @Deprecated
> HTableInterface getTable()
> // users are encouraged to use Connection
> }
> class ConnectionManager {
> createConnection(Configuration) // not sure whether we want a static
> factory method to create connections or a ctor
> }
> @Deprecated
> class HCM extends ConnectionManager {
> // users are encouraged to use ConnectionManager
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
