Enis Soztutar created HBASE-11983:
-------------------------------------
Summary: HRegion constructors should not create HLog
Key: HBASE-11983
URL: https://issues.apache.org/jira/browse/HBASE-11983
Project: HBase
Issue Type: Bug
Reporter: Enis Soztutar
We should get rid of HRegion creating its own HLog. It should ALWAYS get the
log from outside.
I think this was added for unit tests, but we should refrain from such practice
in the future (adding UT constructors always leads to weird and critical bugs
down the road). See recent: HBASE-11982, HBASE-11654.
Get rid of weird things like ignoreHLog:
{code}
/**
* @param ignoreHLog - true to skip generate new hlog if it is null, mostly
for createTable
*/
public static HRegion createHRegion(final HRegionInfo info, final Path
rootDir,
final Configuration conf,
final HTableDescriptor hTableDescriptor,
final HLog hlog,
final boolean initialize, final boolean
ignoreHLog)
{code}
We can unify all the createXX and newXX methods and separate creating a region
in the file system vs opening a region.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
