[ 
https://issues.apache.org/jira/browse/HBASE-12027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14140324#comment-14140324
 ] 

Hadoop QA commented on HBASE-12027:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12669978/HBASE-12027.diff
  against trunk revision .
  ATTACHMENT ID: 12669978

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/10995//console

This message is automatically generated.

> The ZooKeeperWatcher in HMobStore only uses the default conf
> ------------------------------------------------------------
>
>                 Key: HBASE-12027
>                 URL: https://issues.apache.org/jira/browse/HBASE-12027
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: hbase-11339
>            Reporter: Jingcheng Du
>            Assignee: Jingcheng Du
>             Fix For: hbase-11339
>
>         Attachments: HBASE-12027.diff
>
>
> In HMobStore we need to create a ZooKeeperWatcher for a major compaction.
> There the conf of store is directly passed into the ZookeeperWatcher, this 
> conf is a CompoundConfiguration.
> In ZookeeperWatcher, this conf is converted into a Configuration by new 
> Configuration(compoundConfiguration), and the zk-related conf are lost, only 
> default settings are used by the zookeeper.
> In the HMobStore, we should pass the region.getBaseConf() which is a 
> Configuration to the ZookeeperWatcher.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to