[
https://issues.apache.org/jira/browse/HBASE-11879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14141247#comment-14141247
]
Enis Soztutar commented on HBASE-11879:
---------------------------------------
LGTM. Waiting for Nick.
> Change TableInputFormatBase to take interface arguments
> -------------------------------------------------------
>
> Key: HBASE-11879
> URL: https://issues.apache.org/jira/browse/HBASE-11879
> Project: HBase
> Issue Type: Improvement
> Reporter: Carter
> Assignee: Solomon Duskis
> Fix For: 0.99.1
>
> Attachments: HBASE_11879.patch, HBASE_11879_v1.patch
>
>
> As part of the ongoing interface abstraction work, I'm now investigating
> {{TableInputFormatBase}}, which has two methods that break encapsulation:
> {code}
> protected HTable getHTable();
> protected void setHTable(HTable table);
> {code}
> While these are protected methods, the base @InterfaceAudience.Public is
> abstract, meaning that it supports extension by user code.
> I propose deprecating these two methods and replacing them with these four,
> once the Table interface is merged:
> {code}
> protected Table getTable();
> protected void setTable(Table table);
> protected RegionLocator getRegionLocator();
> protected void setRegionLocator(RegionLocator regionLocator);
> {code}
> Since users will frequently call {{setTable}} and {{setRegionLocator}}
> together, it probably also makes sense to add the following convenience
> method:
> {code}
> protected void setTableAndRegionLocator(Table table, RegionLocator
> regionLocator);
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
