[
https://issues.apache.org/jira/browse/HBASE-12030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14142956#comment-14142956
]
Hadoop QA commented on HBASE-12030:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12670237/HBASE-12030.patch
against trunk revision .
ATTACHMENT ID: 12670237
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/11011//console
This message is automatically generated.
> Wrong compaction report and assert when MOB compaction switches to minor
> ------------------------------------------------------------------------
>
> Key: HBASE-12030
> URL: https://issues.apache.org/jira/browse/HBASE-12030
> Project: HBase
> Issue Type: Bug
> Components: Compaction, regionserver
> Affects Versions: hbase-11339
> Reporter: Matteo Bertozzi
> Priority: Critical
> Fix For: hbase-11339
>
> Attachments: HBASE-12030.patch
>
>
> when zookeeper is down during a major compaction or a sweep tool run in
> progress, we switch to a minor.
> {code}
> try {
> zk = MobZookeeper.newInstance(this.conf, compactionName);
> } catch (KeeperException e) {
> LOG.error("Cannot connect to the zookeeper, ready to perform the minor
> compaction instead", e);
> // change the major compaction into a minor one
> compaction.getRequest().setIsMajor(false);
> return super.compact(compaction);
> }
> {code}
> but the "request start" (HRegion.reportCompactionRequestStart) is "major" and
> increments the major-compactions counter
> while the "request end" (HRegion.reportCompactionRequestEnd) is "minor" and
> decrements the minor-compactions counter
> triggering the assert newValue >= 0, since we are decrementing the wrong
> counter
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
